adoroszlai opened a new pull request, #4919:
URL: https://github.com/apache/ozone/pull/4919
## What changes were proposed in this pull request?
Accidental usage of log4j2 code in client can lead to
`NoClassDefFoundError`, since log4j2 is not packaged with shaded FS jars.
Ozone uses log4j2 only for audit logging. Only server-side components
perform audit logging, clients do not need the audit framework, nor log4j2 as a
dependency.
This PR moves
* most of the audit framework to `hdds-server-framework`
* component-specific `AuditAction` implementations to their respective
modules (`SCMAction` to `hdds-server-scm`, etc.)
* datanode-specific audit helper methods from
`ContainerCommandRequestPBHelper` to `HddsDispatcher`, the only place where
they are used
Only the `interface Auditable` is kept in `hdds-common`, since that is
implemented by objects shared between the clients and servers.
Javadoc is slightly updated to account for more recently introduced
`S3GAction`, too.
https://issues.apache.org/jira/browse/HDDS-8860
## How was this patch tested?
CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/5289373013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
