smengcl commented on code in PR #4862:
URL: https://github.com/apache/ozone/pull/4862#discussion_r1232869382
##########
hadoop-ozone/dist/src/main/compose/ozone/test-hadoop.sh:
##########
Review Comment:
Executable bit is gone. Is this intended?
Restore it?
```shell
chmod 755 ./hadoop-ozone/dist/src/main/compose/ozone/test-hadoop.sh
```
##########
hadoop-ozone/dist/src/main/compose/common/hadoop-test.sh:
##########
@@ -16,12 +16,9 @@
# limitations under the License.
export COMPOSE_FILE=docker-compose.yaml:../common/hadoop.yaml
-export HADOOP_MAJOR_VERSION=${HADOOP_VERSION%%.*}
-
-export SECURITY_ENABLED=false
+export HADOOP_MAJOR_VERSION=3
Review Comment:
This can also be `unused`? Since it is set in the for-loop. And both Hadoop
2 and 3 are tested.
##########
hadoop-ozone/dist/src/main/compose/common/hadoop-test.sh:
##########
@@ -36,9 +33,21 @@ export OZONE_DIR=/opt/ozone
# shellcheck source=/dev/null
source "$COMPOSE_DIR/../testlib.sh"
-for scheme in o3fs ofs; do
- execute_robot_test rm -v "SCHEME:${scheme}" -N
"hadoop-${HADOOP_VERSION}-hadoopfs-${scheme}" ozonefs/hadoopo3fs.robot
- execute_robot_test rm -v "SCHEME:${scheme}" -N
"hadoop-${HADOOP_VERSION}-mapreduce-${scheme}" mapreduce.robot
+for HADOOP_VERSION in 2.7.3 3.1.2 3.2.2 3.3.1; do
+ export HADOOP_VERSION
+ export HADOOP_MAJOR_VERSION=${HADOOP_VERSION%%.*}
+
+ docker-compose --ansi never --profile hadoop up -d nm rm
Review Comment:
Just to see if I understand correctly, `--profile hadoop` is unnecessary
since
```
profiles:
- hadoop
```
is already specified in `hadoop.yaml`? I'm fine with keeping it here tho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
