swamirishi commented on code in PR #4884:
URL: https://github.com/apache/ozone/pull/4884#discussion_r1233110613
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -525,22 +525,24 @@ public void start(OzoneConfiguration configuration)
throws IOException {
public static DBStore loadDB(OzoneConfiguration configuration, File metaDir)
throws IOException {
return loadDB(configuration, metaDir, OM_DB_NAME, false,
- java.util.Optional.empty(), true, true);
+ java.util.Optional.empty(), Optional.empty(), true, true);
}
public static DBStore loadDB(OzoneConfiguration configuration, File metaDir,
String dbName, boolean readOnly,
java.util.Optional<Boolean>
- disableAutoCompaction)
+ disableAutoCompaction,
+ java.util.Optional<Integer> maxOpenFiles)
Review Comment:
So that validation is happening on the rocksDb side. We shouldn't add
another layer of redundant validation. If something is wrong it would just
throw exceptions. It is on us to handle it correctly, which I will do as part
of HDDS-8202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
