sodonnel commented on code in PR #4929:
URL: https://github.com/apache/ozone/pull/4929#discussion_r1233866018
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/OzoneClientAdapter.java:
##########
@@ -46,9 +46,17 @@ public interface OzoneClientAdapter {
OzoneFSOutputStream createFile(String key, short replication,
boolean overWrite, boolean recursive) throws IOException;
+ OzoneFSOutputStream createFile(String key, short replication,
+ boolean overWrite, boolean recursive,
+ String ecPolicyName) throws IOException;
Review Comment:
I think the new interface should be:
```
OzoneFSOutputStream createFile(String key, ReplicationConfig repConfig,
boolean overWrite, boolean recursive) throws IOException;
```
This includes replication and EC definitions in a single variable, and is
more consistent with what we have done in other places throughout Ozone.
At the point in distcp where it calls into Ozone, is it via this interface?
Is it possible to create the replicationConfig object there depending on the
files replication or EC definition in distcp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
