errose28 commented on code in PR #4937:
URL: https://github.com/apache/ozone/pull/4937#discussion_r1235662875
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -89,10 +89,10 @@ public class DatanodeConfiguration {
public static final String
OZONE_DATANODE_CHECK_EMPTY_CONTAINER_ON_DISK_ON_DELETE =
- "hdds.datanode.check.empty.container.delete";
+ "hdds.datanode.check.empty.container.on-disk.on.delete";
Review Comment:
Minor suggestion since technically the RocksDB is still being checked and
that is on the disk too.
```suggestion
"hdds.datanode.check.empty.container.dir.on.delete";
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -89,10 +89,10 @@ public class DatanodeConfiguration {
public static final String
OZONE_DATANODE_CHECK_EMPTY_CONTAINER_ON_DISK_ON_DELETE =
- "hdds.datanode.check.empty.container.delete";
+ "hdds.datanode.check.empty.container.on-disk.on.delete";
Review Comment:
Also we should probably add an `@Config` field with a description to make
this consistent with the other configs in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
