smengcl commented on code in PR #4567:
URL: https://github.com/apache/ozone/pull/4567#discussion_r1237616694
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -565,6 +564,8 @@ private synchronized SnapshotDiffResponse submitSnapDiffJob(
volumeName, bucketName, fromSnapshotName, toSnapshotName,
forceFullDiff));
updateJobStatus(jobKey, QUEUED, IN_PROGRESS);
+ // DO NOT decrement snapshot instance ref count, executor is responsible
Review Comment:
Ah. This is a left-over comment that belongs to the old approach before
try-with-resources. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
