sadanand48 commented on code in PR #4947:
URL: https://github.com/apache/ozone/pull/4947#discussion_r1238041334
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -1263,8 +1263,8 @@ private OzoneFileStatus getOzoneFileStatusFSO(OmKeyArgs
args,
return new OzoneFileStatus();
}
- fileStatus = OMFileRequest.getOMKeyInfoIfExists(metadataManager,
- volumeName, bucketName, keyName, scmBlockSize);
+ fileStatus = OMFileRequest.getOMKeyInfoIfExists(ozoneManager,
+ metadataManager, volumeName, bucketName, keyName, scmBlockSize);
Review Comment:
not a major comment but we can pass the default replicationConfig object
here instead of the ozoneManager instance as it is used only to compute only
one member variable just as below in OzoneListStatusHelper constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
