krishnaasawa1 commented on code in PR #4901:
URL: https://github.com/apache/ozone/pull/4901#discussion_r1238176928
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -1352,9 +1356,11 @@ private void deleteInternal(Container container, boolean
force)
// empty as a defensive check.
LOG.error("Could not determine if the container {} is empty",
container.getContainerData().getContainerID(), e);
- throw new StorageContainerException("Could not determine if container "
- + container.getContainerData().getContainerID() +
- " is empty", DELETE_ON_NON_EMPTY_CONTAINER);
+ String errorMsg =
+ "Could not determine if the container " +
container.getContainerData()
+ .getContainerID() + "is empty";
+ triggerVolumeScanAndThrowException(container, errorMsg,
Review Comment:
okay so a single container delete failure here will result in volume scan.
But if volume is found faulty, all containers within that will be removed and
then FCR will be sent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
