adoroszlai commented on code in PR #4885:
URL: https://github.com/apache/ozone/pull/4885#discussion_r1239365508
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -522,6 +522,11 @@ public final class OzoneConfigKeys {
public static final String OZONE_MANAGER_FAIR_LOCK = "ozone.om.lock.fair";
public static final boolean OZONE_MANAGER_FAIR_LOCK_DEFAULT = false;
+ public static final String OZONE_MANAGER_STRIPED_LOCK_SIZE_PREFIX =
+ "ozone.om.lock.striped.size.";
Review Comment:
When working on HDDS-8910 I found Ozone already uses `Striped` in a few
places, and for `ContainerCache` the number of stripes is configurable:
https://github.com/apache/ozone/blob/98abce2e62396fcae554015d483d9d2c0fe0bb05/hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java#L164-L165
I think we should follow this naming convention for consistency, so I'd like
to suggest a small change here:
```suggestion
"ozone.om.lock.stripes.";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
