siddhantsangwan commented on code in PR #4967:
URL: https://github.com/apache/ozone/pull/4967#discussion_r1243631096
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java:
##########
@@ -471,4 +444,37 @@ public ContainerStateManager getContainerStateManager() {
public SCMHAManager getSCMHAManager() {
return haManager;
}
+
+ private static List<ContainerID> filterSortAndLimit(
Review Comment:
Do we even need to sort the list? The interface javadoc does not say that
the returned list will be sorted. I know the earlier implementation is sorting,
and there might be other code that's already relying on a sorted order... But I
think it should be the caller's responsibility to manipulate the data however
they want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
