errose28 commented on code in PR #4867:
URL: https://github.com/apache/ozone/pull/4867#discussion_r1244203899
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -461,6 +507,41 @@ public void validate() {
failedDbVolumesTolerated = FAILED_VOLUMES_TOLERATED_DEFAULT;
}
+ if (volumeIOTestCount < 0) {
+ LOG.warn("{} must be greater than 0 but was set to {}. Defaulting to {}",
+ DISK_CHECK_IO_TEST_COUNT_KEY, volumeIOTestCount,
+ VOLUME_IO_TEST_COUNT_DEFAULT);
+ volumeIOTestCount = VOLUME_IO_TEST_COUNT_DEFAULT;
+ }
+
+ if (volumeIOFailureTolerance < 0) {
+ LOG.warn("{} must be greater than 0 but was set to {}. Defaulting to {}",
+ DISK_CHECK_IO_FAILURES_TOLERATED_KEY, volumeIOFailureTolerance,
+ VOLUME_IO_FAILURES_TOLERATED_DEFAULT);
+ volumeIOFailureTolerance = VOLUME_IO_FAILURES_TOLERATED_DEFAULT;
+ }
+
+ if (volumeIOFailureTolerance >= volumeIOTestCount) {
Review Comment:
Good catch, I will update this to bypass validation of other configs when IO
test count is set to 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
