smengcl opened a new pull request, #4994:
URL: https://github.com/apache/ozone/pull/4994

   ## What changes were proposed in this pull request?
   
   This is a follow-up to HDDS-8166.
   
   As a safety measure, if snapshot feature flag is disabled 
(`ozone.filesystem.snapshot.enabled == false`), block OM from starting up if 
there are still snapshots in the system (i.e. `snapshotInfoTable` is not empty).
   
   This implies any deleted but not reclaimed snapshots will also block OM 
start up in this case, by design.
   
   This should prevent issues with OM HA where some OM has 
`ozone.filesystem.snapshot.enabled` set to `false` but some still have it set 
to `true`. (e.g. if leader has it set to `true` but a follower has it set to 
`false`, when a snapshot request comes in, the follower OM would fail the Tx 
because the feature is disabled)
   
   Related thought: do we have any OM configuration consistency check when an 
OM joins a quorum?
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-8555
   
   ## How was this patch tested?
   
   - Added mock UT.
   - Added integration test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to