xichen01 commented on PR #4939: URL: https://github.com/apache/ozone/pull/4939#issuecomment-1611073293
> Thanks @xichen01 for working on this. License header is missing (reported by `rat`check): > > ``` > hadoop-hdds/server-scm/target/rat.txt: !????? /home/runner/work/ozone/ozone/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/block/TestSCMBlockDeletingService.java > ``` > > https://github.com/xichen01/ozone/actions/runs/5322342178/jobs/9638901446#step:6:831 > > And new config property needs to be added to `ozone-default.xml`, too: > > ``` > Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.47 s <<< FAILURE! - in org.apache.hadoop.ozone.TestOzoneConfigurationFields > Error: org.apache.hadoop.ozone.TestOzoneConfigurationFields.testCompareConfigurationClassAgainstXml Time elapsed: 0.033 s <<< FAILURE! > ... 1 variables missing in ozone-default.xml Entries: ozone.block.deleting.pending.command.limit expected:<0> but was:<1> > ``` > > https://github.com/xichen01/ozone/actions/runs/5322342178/jobs/9638902642#step:5:3834 License header has been added and the new config property has been added to `ozone-default.xml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
