ashishkumar50 commented on code in PR #4961: URL: https://github.com/apache/ozone/pull/4961#discussion_r1245157321
########## hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/security/x509/certificate/utils/TestRootCaRotationPoller.java: ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ +package org.apache.hadoop.hdds.security.x509.certificate.utils; + +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.hdds.protocolPB.SCMSecurityProtocolClientSideTranslatorPB; +import org.apache.hadoop.hdds.security.SecurityConfig; +import org.apache.hadoop.hdds.security.x509.certificate.client.RootCaRotationPoller; +import org.apache.hadoop.security.ssl.KeyStoreTestUtil; +import org.apache.ozone.test.GenericTestUtils; +import org.bouncycastle.cert.jcajce.JcaX509CertificateConverter; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.BeforeEach; +import org.mockito.Mock; +import org.mockito.Mockito; +import org.mockito.MockitoAnnotations; + +import java.io.IOException; +import java.security.KeyPair; +import java.security.cert.X509Certificate; +import java.time.Duration; +import java.time.LocalDateTime; +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.TimeoutException; +import java.util.concurrent.atomic.AtomicBoolean; + +import static org.apache.hadoop.hdds.HddsConfigKeys.HDDS_X509_ROOTCA_CLIENT_POLLING_FREQUENCY; + +/** + * Test for Root Ca Rotation polling mechanism on client side. + */ +public class TestRootCaRotationPoller { + + private SecurityConfig secConf; + + @Mock + private SCMSecurityProtocolClientSideTranslatorPB scmSecurityClient; + + @BeforeEach + public void setup() { + MockitoAnnotations.openMocks(this); + OzoneConfiguration conf = new OzoneConfiguration(); + conf.set(HDDS_X509_ROOTCA_CLIENT_POLLING_FREQUENCY, "PT1s"); + secConf = new SecurityConfig(conf); + } + + @Test + public void testPollerDoesNotInvokeRootCaProcessor() throws IOException { + RootCaRotationPoller poller = new RootCaRotationPoller(secConf, + new HashSet<>(), scmSecurityClient); + + Mockito.when(scmSecurityClient.getAllRootCaCertificates()) + .thenReturn(new ArrayList<>()); + AtomicBoolean atomicBoolean = new AtomicBoolean(); + atomicBoolean.set(false); + poller.addRootCARotationProcessor( + certificates -> CompletableFuture.supplyAsync(() -> { + atomicBoolean.set(true); + Assertions.assertEquals(certificates.size(), 2); + return null; + })); + poller.run(); + Assertions.assertThrows(TimeoutException.class, () -> + GenericTestUtils.waitFor(atomicBoolean::get, 50, 5000)); + } + + @Test + public void testPollerInvokesRootCaProcessors() throws Exception { + X509Certificate knownCert = generateX509Cert( + LocalDateTime.now(), Duration.ofSeconds(50)); + X509Certificate newRootCa = generateX509Cert( + LocalDateTime.now(), Duration.ofSeconds(50)); + HashSet<X509Certificate> knownCerts = new HashSet<>(); + knownCerts.add(knownCert); + List<String> certsFromScm = new ArrayList<>(); + certsFromScm.add(CertificateCodec.getPEMEncodedString(knownCert)); + certsFromScm.add(CertificateCodec.getPEMEncodedString(newRootCa)); Review Comment: Can you have small test by just adding knowCert to ensure both cases are fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
