sodonnel commented on PR #4998: URL: https://github.com/apache/ozone/pull/4998#issuecomment-1611591255
Changes LGTM. I had originally thought we should expose a metrics for the number of entries pending in the moveManager. I guess these new perIteration metrics cover it, as each iteration should start with everything from the last timed out or completed. There may be a small chance that something goes wrong and allows entries to build up in the moveManager pending table, but perhaps adding a metric for that is not needed. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
