vtutrinov commented on code in PR #3760:
URL: https://github.com/apache/ozone/pull/3760#discussion_r1247734992
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java:
##########
@@ -282,6 +281,10 @@ private void processCmd(DeleteCmdInfo cmd) {
List<Future> futures = new ArrayList<>();
for (int i = 0; i < containerBlocks.size(); i++) {
DeletedBlocksTransaction tx = containerBlocks.get(i);
+ // Container is being balanced, ignore this transaction
+ if (shouldAbandon(tx.getContainerID(), cmd.getContainer())) {
+ continue;
Review Comment:
Shouldn't we be throwing some kind of exception here to tell the user that
the operation can't be performed right now (including a detailed reason
message)? (the same notice is for DeleteContainerCommandHandler)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
