hemantk-12 commented on code in PR #5007:
URL: https://github.com/apache/ozone/pull/5007#discussion_r1248317625
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java:
##########
@@ -70,7 +70,8 @@ public static SnapshotInfo getSnapshotInfo(final OzoneManager
ozoneManager,
throw e;
}
if (snapshotInfo == null) {
- throw new OMException(KEY_NOT_FOUND);
+ throw new OMException("Snapshot '" + snapshotKey + "' is not found.",
Review Comment:
You are right. But I'm just thinking from client perspective `snapshotName`
would be better which can be extracted from the `snapshotKey` I guess. At the
same time it is not a big deal to return `snapshotKey` in exception message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
