fapifta commented on code in PR #5009: URL: https://github.com/apache/ozone/pull/5009#discussion_r1252405540
########## hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/security/x509/package-info.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + + +/** + * This package contains common routines used in creating an x509 based identity + * framework for HDDS. + */ +package org.apache.hadoop.hdds.security.x509; +/* + +Architecture of Certificate Infrastructure for SCM. +==================================================== Review Comment: Actually this description is somewhat the tldr of the original design document in HDDS-4. Parts of it is obsolete, some parts were never implemented. I decided to remove this, as with the current and recent changes we'd better write a solid documentation page rather than trying to summarize this in the APIDoc I believe. I removed the duplicated package-info file form the hdds/framework module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
