symious commented on code in PR #4887:
URL: https://github.com/apache/ozone/pull/4887#discussion_r1254016823
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -327,7 +335,25 @@ public BackgroundTaskQueue getTasks() {
return queue;
}
- // TODO: Implementation for choose tasks
+ for (int i = 0; i < availableTaskCount; i++) {
+ Pair<HddsVolume, HddsVolume> pair = volumeChoosingPolicy
+ .chooseVolume(volumeSet, threshold, deltaSizes);
+ if (pair == null) {
+ continue;
+ }
+ HddsVolume sourceVolume = pair.getLeft(), destVolume = pair.getRight();
+ ContainerData toBalanceContainer = containerChoosingPolicy
+ .chooseContainer(ozoneContainer, sourceVolume, inProgressContainers);
+ if (toBalanceContainer != null) {
+ queue.add(new DiskBalancerTask(toBalanceContainer, sourceVolume,
+ destVolume));
+ inProgressContainers.add(toBalanceContainer.getContainerID());
Review Comment:
I was thinking we can drop the commands and let SCM resend the commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
