ChenSammi commented on code in PR #4938:
URL: https://github.com/apache/ozone/pull/4938#discussion_r1259331932


##########
hadoop-hdds/docs/content/security/SecurityAcls.md:
##########
@@ -78,16 +78,86 @@ allows the user to overwrite an existing ozone key.
 6. **Read_ACL** – Allows a user to read the ACL on a specific object.
 7. **Write_ACL** – Allows a user to write the ACL on a specific object.
 
-<h3>Ozone Native ACL APIs</h3>
+There are 2 types of ACLs based on their scope - **Access** and 
**Default**.<br>
+Access ACLs are limited only to the specific object and not inherited. They 
control the access to the object itself.
+Only Default ACLs support inheritance. This inheritance is limited to only one 
level. For example,
+Any bucket created under a volume which has a Default ACL inherits that 
Default ACL as an Access ACLs. 

Review Comment:
   > > This inheritance is limited to only one level
   > 
   > This point may be debatable. In the case of FSO or LEGACY (Ignore OBS due 
to OBS key inherits the DEFAULT ACLs of the bucket):
   > 
   >     1. If a bucket has the DEFAULT ACLs, does the ACLs that sub-directory 
inherited should have DEFAULT scope?
   > 
   >     2. Does the sub-directory inherit the DEFAULT ACLs of the bucket or 
the parent directory?
   > 
   > 
   > Maybe we can wait for clearing up first. cc @ChenSammi see: 
[HDDS-8653](https://issues.apache.org/jira/browse/HDDS-8653) #4752
   
   @whbing @Tejaskriya ,
   
   I think the ACLs that sub-directory inherited from its parent should have 
DEFAULT scope too. Inheritance should apply all the way down to the 
descendants.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to