adoroszlai commented on code in PR #5038:
URL: https://github.com/apache/ozone/pull/5038#discussion_r1259788519
##########
hadoop-ozone/dist/src/main/smoketest/admincli/scmrole.robot:
##########
@@ -25,4 +25,8 @@ Test Timeout 5 minutes
*** Test Cases ***
Run scm roles
${output} = Execute ozone admin scm roles
- Should Match Regexp ${output} [scm:9894(:LEADER|)]
\ No newline at end of file
+ Should Match Regexp ${output} [scm:9894(:LEADER|)]
+
+List scm roles as JSON
+ ${output} = Execute ozone admin scm roles --json
+ Should contain ${output} "address" :
Review Comment:
We can check that output is valid JSON by passing through `jq`, e.g. find
LEADER:
```suggestion
Execute echo '${output}' | jq -r '.[] |
select(.raftPeerRole == "LEADER")'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
