sumitagrawl commented on code in PR #4988:
URL: https://github.com/apache/ozone/pull/4988#discussion_r1260494268


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -515,6 +516,17 @@ public List<SCMCommand> processHeartbeat(DatanodeDetails 
datanodeDetails,
           commandQueue.getDatanodeCommandSummary(datanodeDetails.getUuid());
       List<SCMCommand> commands =
           commandQueue.getCommand(datanodeDetails.getUuid());
+
+      // Update the SCMCommand of deleteBlocksCommand Status
+      for (SCMCommand command : commands) {

Review Comment:
   can have a sentTriggerMap, like
   Map<CommandType, ICommandSend> sendCommandNotifyMap;
   ICommandSend {
       void notify(List<SCMComand);
   }
   
   register(CommandType, ICommandSend handler) {
       sendCommanNotifyMap.add(DELELTEBlockCommand, handler);
   }
   
   handler can have above logic to update status.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to