whbing commented on code in PR #4738:
URL: https://github.com/apache/ozone/pull/4738#discussion_r1261442403
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java:
##########
@@ -236,19 +235,19 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
omMetadataManager.getBucketKey(volumeName, bucketName));
// If FILE_EXISTS we just override like how we used to do for Key Create.
- List< OzoneAcl > inheritAcls;
if (LOG.isDebugEnabled()) {
LOG.debug("BucketName: {}, BucketLayout: {}",
bucketInfo.getBucketName(), bucketInfo.getBucketLayout());
}
+
+ OMFileRequest.OMPathInfo pathInfo =
Review Comment:
> @whbing For OBS case, there is no directory or parent path, all key
belongs to bucket only. If above is used to get pathInfo, and if mistakely key
name pattern follows FSO naming, and parent directory exist, then it will
inherit the ACL of the parent key present (which is another Key). So this can
be incorrect to have ACL from another key in OBS case.
>
> So we need do only inside if EnableFileSystem, and null can be passed in
prepareKeyInfo for pathInfo.
@sumitagrawl Thanks, got it and already fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
