prashantpogde commented on code in PR #5045:
URL: https://github.com/apache/ozone/pull/5045#discussion_r1261963404
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -885,14 +885,21 @@ public void createTenant(String tenantId, TenantArgs
tenantArgs)
final String volumeName = tenantArgs.getVolumeName();
verifyVolumeName(volumeName);
+ final boolean forceCreationWhenVolumeExists =
+ tenantArgs.getForceCreationWhenVolumeExists();
+
OmTenantArgs.Builder builder = OmTenantArgs.newBuilder();
builder.setTenantId(tenantId);
builder.setVolumeName(volumeName);
- // TODO: Add more fields
- // TODO: Include OmVolumeArgs in (Om)TenantArgs as well for volume
creation?
+ builder.setForceCreationWhenVolumeExists(
+ tenantArgs.getForceCreationWhenVolumeExists());
+
+ // TODO: Add more fields. e.g. include OmVolumeArgs in (Om)TenantArgs
Review Comment:
do we need TODO ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
