errose28 commented on code in PR #5065:
URL: https://github.com/apache/ozone/pull/5065#discussion_r1265792749


##########
hadoop-ozone/dist/src/main/smoketest/basic/links.robot:
##########
@@ -114,9 +114,13 @@ Key list passthrough
                         Should Contain              ${source_list}    key2
 
 Key delete passthrough
-                        Execute                     ozone sh key delete 
--skipTrash ${target}/link1/key2
-    ${source_list} =    Execute                     ozone sh key list 
${source}/bucket1 | jq -r '.[].name'
-                        Should Not Contain          ${source_list}    key2
+                        Execute                     ozone sh key delete 
${target}/link1/key2
+                        Execute                     ozone sh key list 
${source}/bucket1 > bucket1keylist.json

Review Comment:
   We should probably delete this file in the test teardown. Also saving to a 
string may be easier than the file since the key list output should not be that 
large. @adoroszlai what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to