SaketaChalamchala commented on code in PR #5072:
URL: https://github.com/apache/ozone/pull/5072#discussion_r1268683265
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/s3/multipart/TestS3InitiateMultipartUploadRequest.java:
##########
@@ -69,9 +70,13 @@ public void testValidateAndUpdateCache() throws Exception {
modifiedRequest.getInitiateMultiPartUploadRequest()
.getKeyArgs().getMultipartUploadID());
- Assert.assertNotNull(omMetadataManager
+ OmKeyInfo openMPUKeyInfo = omMetadataManager
.getOpenKeyTable(s3InitiateMultipartUploadRequest.getBucketLayout())
- .get(multipartKey));
+ .get(multipartKey);
+ Assert.assertNotNull(openMPUKeyInfo);
+ Assert.assertNotNull(openMPUKeyInfo.getLatestVersionLocations());
+ Assert.assertTrue(openMPUKeyInfo.getLatestVersionLocations()
+ .isMultipartKey());
Review Comment:
Thanks for the patch @ivandika3.
nit: Could you also replace the actual value in assertions at L88 and L93
with `openMPUKeyInfo.getModificationTime()` and
`openMPUKeyInfo.getCreationTime()` just to make it cleaner.
Otherwise, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
