[ 
https://issues.apache.org/jira/browse/HDDS-8705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745229#comment-17745229
 ] 

Siyao Meng commented on HDDS-8705:
----------------------------------

I'm checking the coverage again. Looks like we got >82% coverage over the board 
for crucial snapshot routines:

82.2% under 
`hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot`:

https://sonarcloud.io/component_measures?metric=coverage&selected=hadoop-ozone%3Ahadoop-ozone%2Fozone-manager%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhadoop%2Fozone%2Fom%2Fsnapshot&id=hadoop-ozone

92.4% under Ozone snapshot-related Ratis requests 
`hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot`:

https://sonarcloud.io/component_measures?metric=coverage&selected=hadoop-ozone%3Ahadoop-ozone%2Fozone-manager%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhadoop%2Fozone%2Fom%2Frequest%2Fsnapshot&id=hadoop-ozone

89.0% under response 
`hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/snapshot`:

https://sonarcloud.io/component_measures?metric=coverage&selected=hadoop-ozone%3Ahadoop-ozone%2Fozone-manager%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhadoop%2Fozone%2Fom%2Fresponse%2Fsnapshot&id=hadoop-ozone

Thanks a lot for covering the test cases in the past few months [~hemantk] 
[~swamirishi] [~dteng] [~georgeJahad] [~mladjangadzic] .

I'm going to close this jira.

> [Snapshot] Check snapshot feature code coverage
> -----------------------------------------------
>
>                 Key: HDDS-8705
>                 URL: https://issues.apache.org/jira/browse/HDDS-8705
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: Snapshot, test
>            Reporter: Siyao Meng
>            Priority: Major
>
> Should be able to leverage SonarCloud for it:
> https://sonarcloud.io/summary/overall?id=hadoop-ozone
> Looks like we could even click into each file to see whether each chunk of 
> code is covered:
> https://sonarcloud.io/component_measures?metric=new_conditions_to_cover&selected=hadoop-ozone%3Ahadoop-ozone%2Fozone-manager%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhadoop%2Fozone%2Fom%2Fsnapshot&id=hadoop-ozone
> The goal is to cover all conditions in snapshot lifecycle. File a new jira to 
> add tests for missing ones.
> cc [~georgeJahad] [~ppogde] [~hemantk] [~aswinshakil] [~swamirishi] [~dteng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to