siddhantsangwan commented on PR #5084: URL: https://github.com/apache/ozone/pull/5084#issuecomment-1645428677
The idea of increasing the maximum number of pipelines if all the existing ones have been excluded looks good to me. I have some thoughts on what the new limit should be. Setting it to number of healthy, in service datanodes makes sense, but there are edge cases where the maximum number of pipelines is already greater than the number of datanodes. One such case is when there are 5 datanodes, and each datanode has 8 (or any number greater than the datanode count) volumes. In this case, the max is 8. In general, if the pipeline per volume factor or the number of volumes is high enough, then max pipelines will already be greater than the number of datanodes. So, what should the new limit be? This is an edge case, and number of datanodes amount of pipelines already sounds high enough, so I'm good with the current change. Another simple option is `maximumPipelines + 5`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
