adoroszlai commented on PR #5085: URL: https://github.com/apache/ozone/pull/5085#issuecomment-1646046751
Thanks @fapifta for the review. > Shouldn't we separate these into different compose directories as well? Previously we had different directories, duplicating the cluster definition/configs, with very minor differences. One reason to have multiple test scripts per directory is to avoid that. Test scripts that can be generalised to different clusters can be placed in separate directories (e.g. `common`). Currently only `hadoop-ozone/dist/src/main/compose/common/hadoop-test.sh` is such a test. For example if we can implement `test-certificate-rotation.sh` in a way to be applicable to both HA and non-HA case, we can move it to another dir. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
