hemantk-12 commented on code in PR #5083:
URL: https://github.com/apache/ozone/pull/5083#discussion_r1269947737
##########
.github/workflows/ci.yml:
##########
@@ -26,13 +26,13 @@ jobs:
GITHUB_CONTEXT: ${{ toJson(github) }}
outputs:
basic-checks: ${{ steps.selective-checks.outputs.basic-checks }}
- needs-basic-checks: ${{
steps.selective-checks.outputs.needs-basic-checks }}
- needs-build: ${{ steps.selective-checks.outputs.needs-build }}
- needs-compile: ${{ steps.selective-checks.outputs.needs-compile }}
- needs-compose-tests: ${{
steps.selective-checks.outputs.needs-compose-tests }}
- needs-dependency-check: ${{
steps.selective-checks.outputs.needs-dependency-check }}
+ needs-basic-checks: false
Review Comment:
I'm guessing workflow changes are for just testing on the your fork and will
be reverted later.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMRatisSnapshots.java:
##########
@@ -143,6 +162,20 @@ public void init(TestInfo testInfo) throws Exception {
StorageUnit.KB);
conf.setStorageSize(OMConfigKeys.
OZONE_OM_RATIS_SEGMENT_PREALLOCATED_SIZE_KEY, 16, StorageUnit.KB);
+ if (testInfo.getDisplayName().equals("testSnapshotBackgroundServices")) {
Review Comment:
nit: constant should be put on the right side.
```suggestion
if ("testSnapshotBackgroundServices".equals(testInfo.getDisplayName())) {
```
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMRatisSnapshots.java:
##########
@@ -143,6 +162,20 @@ public void init(TestInfo testInfo) throws Exception {
StorageUnit.KB);
conf.setStorageSize(OMConfigKeys.
OZONE_OM_RATIS_SEGMENT_PREALLOCATED_SIZE_KEY, 16, StorageUnit.KB);
+ if (testInfo.getDisplayName().equals("testSnapshotBackgroundServices")) {
+ conf.setTimeDuration(OZONE_SNAPSHOT_SST_FILTERING_SERVICE_INTERVAL,
+ 5, TimeUnit.SECONDS);
+ conf.setTimeDuration(OZONE_SNAPSHOT_DELETING_SERVICE_INTERVAL, 5,
+ TimeUnit.SECONDS);
+ conf.setTimeDuration(OZONE_OM_SNAPSHOT_COMPACTION_DAG_MAX_TIME_ALLOWED,
Review Comment:
I don't think you need to override
`OZONE_OM_SNAPSHOT_COMPACTION_DAG_MAX_TIME_ALLOWED` unless you are testing DAG
and compaction log pruning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
