smengcl commented on code in PR #5108:
URL: https://github.com/apache/ozone/pull/5108#discussion_r1272951701
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java:
##########
@@ -383,16 +386,27 @@ protected void testCreateFile(OzoneBucket ozoneBucket,
String keyName,
OzoneKeyDetails ozoneKeyDetails = ozoneBucket.getKey(keyName);
- Assert.assertEquals(keyName, ozoneKeyDetails.getName());
- Assert.assertEquals(ozoneBucket.getName(),
ozoneKeyDetails.getBucketName());
- Assert.assertEquals(ozoneBucket.getVolumeName(),
+ assertEquals(keyName, ozoneKeyDetails.getName());
+ assertEquals(ozoneBucket.getName(), ozoneKeyDetails.getBucketName());
+ assertEquals(ozoneBucket.getVolumeName(),
ozoneKeyDetails.getVolumeName());
- Assert.assertEquals(data.length(), ozoneKeyDetails.getDataSize());
+ assertEquals(data.length(), ozoneKeyDetails.getDataSize());
+ assertTrue(ozoneKeyDetails.isFile());
try (OzoneInputStream ozoneInputStream = ozoneBucket.readKey(keyName)) {
byte[] fileContent = new byte[data.getBytes(UTF_8).length];
ozoneInputStream.read(fileContent);
- Assert.assertEquals(data, new String(fileContent, UTF_8));
+ assertEquals(data, new String(fileContent, UTF_8));
+ }
+
+ Iterator<? extends OzoneKey> iterator = ozoneBucket.listKeys("/");
+ while (iterator.hasNext()) {
+ OzoneKey ozoneKey = iterator.next();
+ if (Objects.equals(keyName, ozoneKey.getName())) {
+ assertTrue(ozoneKey.isFile());
+ } else if (keyName.startsWith(ozoneKey.getName())) {
+ assertFalse(ozoneKey.isFile());
+ }
Review Comment:
Is it the same to use `/` in the condition?
```suggestion
if (!ozoneKey.getName().endsWith(OM_KEY_PREFIX)) {
assertTrue(ozoneKey.isFile());
} else {
assertFalse(ozoneKey.isFile());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
