ChenSammi commented on PR #5064: URL: https://github.com/apache/ozone/pull/5064#issuecomment-1649119284
> Thank you for your work @ChenSammi, overall the changes look good, I have some general quesiton though: As I understand, during the rootCA rotation we start a task that will cancel the post rotation phase if leadership is transferred to an other SCM, this is done in the notifyStatusChanged method within the RootCARotationManager. Other SCMs during the prepare ack will start a similar timer, so that once a leader change happens, those timers remain active, again if I understand correctly. > > However I am not sure what will happen if there are two subsequent leadership transfer like: SCM1->SCM2-SCM1? But my understanding is that in this case the notifyStatusChanged would be a place to check if we are still in the post processing period. > > There is one more case, when all 3 SCMs are restarted at once during the processing period, in which case the SCM does not seem to activate the post processing period and does not disable certificate signing further, which can be a problem if other services are not restarted together with the SCMs and their poller does not run. @fapifta , good catch. A new commit is uploaded to handle the leader transfer and service restart cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
