duongkame commented on code in PR #5118:
URL: https://github.com/apache/ozone/pull/5118#discussion_r1275619835
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/GrpcContainerUploader.java:
##########
@@ -60,8 +61,9 @@ public OutputStream startUpload(long containerId,
DatanodeDetails target,
StreamObserver<SendContainerRequest> requestStream = client.upload(
new SendContainerResponseStreamObserver(containerId, target,
callback));
- return new SendContainerOutputStream(requestStream, containerId,
- GrpcReplicationService.BUFFER_SIZE, compression) {
+ return new SendContainerOutputStream(
+ (CallStreamObserver<SendContainerRequest>) requestStream,
Review Comment:
actually, we don't take the `SendContainerResponseStreamObserver` as the
input for SendContainerOutputStream, but the StreamObserver given by gRPC. And
`StreamObserver` is the type gRPC gives. Internally, it returns an instance
that implements `CallStreamObserver`, the reduces the result type to
`StreamObserver`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
