umamaheswararao commented on code in PR #5126:
URL: https://github.com/apache/ozone/pull/5126#discussion_r1276599851
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -243,6 +243,7 @@ public ReplicationManager(final ConfigurationSource conf,
this.ratisReplicationCheckHandler =
new RatisReplicationCheckHandler(ratisContainerPlacement);
this.nodeManager = nodeManager;
+ this.metrics = ReplicationManagerMetrics.create(this);
Review Comment:
In general this looks good to me.
Actually startSubservices happening after creating metrics.
protected void startSubServices() {
replicationMonitor = new Thread(this::run);
replicationMonitor.setName("ReplicationMonitor");
replicationMonitor.setDaemon(true);
replicationMonitor.start();
underReplicatedProcessorThread = new Thread(underReplicatedProcessor);
underReplicatedProcessorThread.setName("Under Replicated Processor");
underReplicatedProcessorThread.setDaemon(true);
underReplicatedProcessorThread.start();
overReplicatedProcessorThread = new Thread(overReplicatedProcessor);
overReplicatedProcessorThread.setName("Over Replicated Processor");
overReplicatedProcessorThread.setDaemon(true);
overReplicatedProcessorThread.start();
}
So, this UnhealthyProcessor thread starting before? I didn't find where
that thread starting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
