hemantk-12 commented on PR #5115: URL: https://github.com/apache/ozone/pull/5115#issuecomment-1654774426
> > Just a thought, wouldn't it be easier if you just don't populate extra information when listing keys for the `listKeys` API? By default API will return only necessary information. An extra parameter can be added to the existing list API to return full key information. Or vice versa for backward compatibility. > > I see we have something similar already in [listKeys API](https://github.com/apache/ozone/blob/607b67eeeca4e4f88ae7913fc898a9c22282f758/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java#L682). > > We discussed this and felt it is simpler to keep separate lightweight APIs that behave in one way rather than APIs that are multi modal and have variable responses based on varying parameters. Keeping the APIs simple will also help in measuring runtime performance of the APIs for OM vs. not knowing the parameters involved. Thanks @kerneltime. Based on your comment, I see why we are going with new API approach. @tanvipenumudy the motivation behind this change is not very clear from the PR's description or attached jira. If there is a feature jira or design doc where motivation is captured, it would be great if you attached to PR or jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
