swamirishi commented on code in PR #5127:
URL: https://github.com/apache/ozone/pull/5127#discussion_r1278086826
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java:
##########
@@ -89,13 +89,17 @@ public class SstFilteringService extends BackgroundService
private AtomicBoolean running;
- private BooleanTriFunction<String, String, String, Boolean> filterFunction =
- (first, last, prefix) -> {
- String firstBucketKey = RocksDiffUtils.constructBucketKey(first);
- String lastBucketKey = RocksDiffUtils.constructBucketKey(last);
- return RocksDiffUtils
- .isKeyWithPrefixPresent(prefix, firstBucketKey, lastBucketKey);
- };
+ // Note: This filter only works till snapshots are readable only.
+ // In the future, if snapshots are changed to writable as well,
+ // this will need to be revisited.
+ static final BooleanTriFunction<String, String, String, Boolean>
Review Comment:
any reason to make it static? You can let it be a package private member.
SSTFiltering service will have only single instance anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
