devmadhuu commented on code in PR #5090:
URL: https://github.com/apache/ozone/pull/5090#discussion_r1278884599
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/heatMap/heatMapConfiguration.tsx:
##########
@@ -79,17 +74,19 @@ export default class HeatMapConfiguration extends Component
{
fontSize: 12
},
tileStroke: 'white',
Review Comment:
Can you pls change this as well to RGB code ?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/heatMap/heatmap.tsx:
##########
@@ -66,60 +117,61 @@ export class Heatmap extends
React.Component<Record<string, object>, ITreeState>
entityType: 'key',
inputPath: '/',
date: '24H',
- treeEndpointFailed: false
+ treeEndpointFailed: false,
+ inputPathValid: undefined,
+ helpMessage: ""
};
}
handleCalendarChange = (e: any) => {
if (e.key === '24H' || e.key === '7D' || e.key === '90D') {
- this.setState((prevState, newState) => ({
+ this.setState((prevState, _newState) => ({
date: e.key,
inputPath: prevState.inputPath,
entityType: prevState.entityType
}), () => {
- this.updateTreeMap(this.state.inputPath, this.state.entityType,
this.state.date)
+ this.updateTreeMap(this.state.inputPath, this.state.entityType,
this.state.date);
});
}
};
handleMenuChange = (e: any) => {
- if (e.key === 'volume' || e.key === 'bucket' || e.key === 'key')
- {
- minSize=Infinity;
+ if (e.key === 'volume' || e.key === 'bucket' || e.key === 'key') {
Review Comment:
Pls define 'volume', 'bucket' and 'key' also as global constants at one
place.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/heatMap/heatmap.tsx:
##########
@@ -66,60 +117,61 @@ export class Heatmap extends
React.Component<Record<string, object>, ITreeState>
entityType: 'key',
inputPath: '/',
date: '24H',
Review Comment:
I am seeing some of the values are used frequently through out the code like
'24H', 'key' , '/' etc. Is it possible to define them as global constants and
use them ?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/heatMap/heatmap.tsx:
##########
@@ -51,11 +51,62 @@ interface ITreeState {
entityType: string;
date: string;
treeEndpointFailed: boolean;
+ inputPathValid: inputPathValidity;
+ helpMessage: string;
}
let minSize = Infinity;
let maxSize = 0;
+const colourScheme = {
+ pastel_greens: [
Review Comment:
I am not sure when this green shades will appear, as there are 3 categories,
the access of volume/buckets/keys, may fall under like Most Frequently accessed
(MFA - Red), Frequently Accessed (FA - Orange), Least Accessed (LA - Yellow).
Under which category and how this shade of green will appear ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
