hemantk-12 commented on code in PR #5139:
URL: https://github.com/apache/ozone/pull/5139#discussion_r1282392241
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java:
##########
@@ -383,6 +383,11 @@ private OMConfigKeys() {
public static final String
OZONE_SNAPSHOT_SST_FILTERING_SERVICE_INTERVAL_DEFAULT = "60s";
+ public static final String OZONE_SNAPSHOT_DIR_CHECK_POLL_TIMEOUT =
Review Comment:
nit:
1. I think OM specific keys are supposed to follow `ozone.om.*`.
2. may be `ozone.om.snapshot.checkpoint.dir.creation.poll.timeout` .
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBCheckpointUtils.java:
##########
@@ -45,13 +45,14 @@ private RDBCheckpointUtils() { }
* Wait for checkpoint directory to be created for 5 secs with 100 millis
* poll interval.
* @param file Checkpoint directory.
+ * @param pollMaxDuration max duration for polling
* @return true if found.
*/
- public static boolean waitForCheckpointDirectoryExist(File file)
- throws IOException {
+ public static boolean waitForCheckpointDirectoryExist(File file,
+ Duration pollMaxDuration) {
Review Comment:
nit: alignment is not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
