hemantk-12 commented on code in PR #5145:
URL: https://github.com/apache/ozone/pull/5145#discussion_r1283778883
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -326,13 +329,17 @@ public void setCurrentCompactionLog(long
latestSequenceNum) {
appendToCurrentCompactionLog("");
}
+
@Override
- public void close() {
- synchronized (this) {
- if (!closed) {
- closed = true;
- if (executor != null) {
- executor.shutdown();
+ public void close() throws Exception {
Review Comment:
It is not required. It was added because I used IDE to add this method and
`AutoCloseable#close()` throws an exception. I leave it as it is unless there
is a major concern about it. Also we are using `IOUtils.closeQuietly()` so
exception will be logged and swallowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
