fapifta commented on PR #5150: URL: https://github.com/apache/ozone/pull/5150#issuecomment-1665927520
Hi @ChenSammi, thank you for working on this, I have a fundamental problem with publishing the notifyNotificationReceivers method. With that any class can initiate sending a notification about refreshed certificates, but in my mind, the internal handling of the rootCA certificate, and the actual service's certificate is something we would like to have handled inside the certificate client. I have added a PR to your branch, to showcase how I would solve the problem, with extending the SCMCertificateClient instead of the SCMHAManager with the task of refreshing the rootCA certificate. Please take a look, and let me know what do you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
