mladjan-gadzic commented on PR #5083: URL: https://github.com/apache/ozone/pull/5083#issuecomment-1666122945
> Thanks for the patch @mladjan-gadzic. It is great addition to the CD/CI. > > LGTM. > > One suggestion as @smengcl mentioned [here](https://github.com/apache/ozone/pull/5083#discussion_r1280535927), we should try to make components/blocks for lengthy code like this. Using blocks improves the readability as well as you can get rid of comments stating the obvious IMO. Thanks @hemantk-12 for taking the time to review it! I just pushed changes which should improve readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
