prashantpogde commented on code in PR #5158:
URL: https://github.com/apache/ozone/pull/5158#discussion_r1286497986
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java:
##########
@@ -187,9 +174,8 @@ public BackgroundTaskResult call() throws Exception {
}
// mark the snapshot as filtered by writing to the file
- String content = snapshotInfo.getSnapshotId() + "\n";
- Files.write(filePath, content.getBytes(StandardCharsets.UTF_8),
- StandardOpenOption.CREATE, StandardOpenOption.APPEND);
+ snapshotInfo.setSstFiltered(true);
+ snapshotInfoTable.put(snapShotTableKey, snapshotInfo);
Review Comment:
Lock/Serializsation needed ? Other services could be changing the snapshot
Info fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
