dombizita commented on code in PR #5153:
URL: https://github.com/apache/ozone/pull/5153#discussion_r1286981902
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneClientMultipartUploadWithFSO.java:
##########
@@ -406,6 +406,28 @@ public void testMultipartUploadWithMissingParts() throws
Exception {
() -> completeMultipartUpload(bucket, keyName, uploadID, partsMap));
}
+ @Test
+ public void testMultipartPartNumberExceedingAllowedRange() throws Exception {
+ // https://docs.aws.amazon.com/AmazonS3/latest/userguide/qfacts.html
+ keyName = UUID.randomUUID().toString();
Review Comment:
nit, this is not necessary, in `preTest()` it is already there.
also I don't think the link is needed above (as you added a comment later
with the necessary information), but I leave this up to you
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java:
##########
@@ -2966,6 +2966,36 @@ public void testMultipartUploadWithMissingParts() throws
Exception {
() -> completeMultipartUpload(bucket, keyName, uploadID, partsMap));
}
+ @Test
+ public void testMultipartPartNumberExceedingAllowedRange() throws Exception {
+ // https://docs.aws.amazon.com/AmazonS3/latest/userguide/qfacts.html
Review Comment:
same here
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -919,6 +919,11 @@ private Response createMultipartKey(OzoneVolume volume,
String bucket,
throw newError(NO_SUCH_UPLOAD, uploadID, ex);
} else if (isAccessDenied(ex)) {
throw newError(S3ErrorTable.ACCESS_DENIED, bucket + "/" + key, ex);
+ } else if ((ex.getResult() == ResultCodes.INVALID_PART)) {
Review Comment:
nit
```suggestion
} else if (ex.getResult() == ResultCodes.INVALID_PART) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
