swamirishi commented on code in PR #5155:
URL: https://github.com/apache/ozone/pull/5155#discussion_r1287242150
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java:
##########
@@ -170,33 +182,38 @@ public BackgroundTaskResult call() throws Exception {
Table.KeyValue<String, SnapshotInfo> keyValue = iterator.next();
String snapShotTableKey = keyValue.getKey();
SnapshotInfo snapshotInfo = keyValue.getValue();
+ if (snapshotInfo.getSnapshotStatus()
Review Comment:
this should not be there.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java:
##########
@@ -152,7 +162,8 @@ public BackgroundTaskResult call() throws
InterruptedException {
// Only Iterate in deleted snapshot
if (!snapshotStatus.equals(
- SnapshotInfo.SnapshotStatus.SNAPSHOT_DELETED)) {
+ SnapshotInfo.SnapshotStatus.SNAPSHOT_DELETED) ||
Review Comment:
We need a similar check in OMSnapshotPurgeRequest. As in we should process
this request only when snapshot is sstFiltered. We can also think of pausing
the sst filtering service if it so happens that the snapshot is not sstFiltered
but it has made it to the request. This scenario can happen if the request has
gone through when sstFiltering service was not running and om restarted with a
config change starting the sstFilteringService.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java:
##########
@@ -170,33 +182,38 @@ public BackgroundTaskResult call() throws Exception {
Table.KeyValue<String, SnapshotInfo> keyValue = iterator.next();
String snapShotTableKey = keyValue.getKey();
SnapshotInfo snapshotInfo = keyValue.getValue();
+ if (snapshotInfo.getSnapshotStatus()
Review Comment:
SSTFiltering service should also process inactive snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
