hemantk-12 commented on code in PR #5155:
URL: https://github.com/apache/ozone/pull/5155#discussion_r1287694525
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java:
##########
@@ -147,12 +148,12 @@ public BackgroundTaskResult call() throws
InterruptedException {
while (iterator.hasNext() && snapshotLimit > 0) {
SnapshotInfo snapInfo = iterator.next().getValue();
- SnapshotInfo.SnapshotStatus snapshotStatus =
- snapInfo.getSnapshotStatus();
+ boolean isSstFilteringServiceEnabled =
+ ((KeyManagerImpl) ozoneManager.getKeyManager())
+ .isSstFilteringSvcEnabled();
// Only Iterate in deleted snapshot
- if (!snapshotStatus.equals(
- SnapshotInfo.SnapshotStatus.SNAPSHOT_DELETED)) {
+ if (shouldIgnoreSnapshot(snapInfo, isSstFilteringServiceEnabled)) {
Review Comment:
Curious if we need to have end to end test in `TestSnapshotDeletingService`
as well or
[this](https://github.com/apache/ozone/pull/5155/files#diff-c4c691f6dfa73df833ed29be86d77ef32b206052a5c69febef2c39eaef5fcc51R256)
is enough?.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
