kerneltime commented on code in PR #5161:
URL: https://github.com/apache/ozone/pull/5161#discussion_r1287718789


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/GrpcOutputStream.java:
##########
@@ -147,10 +149,12 @@ private void flushBuffer(boolean eof) {
    * the stream until it's ready.
    */
   private void waitUntilReady() {
-    while (!streamObserver.isReady()) {
+    int count = 0;
+    while (!streamObserver.isReady() && count < READY_RETRY_COUNT) {

Review Comment:
   Won't this lead to the same memory bloat? Retrying the whole container 
replication might be better if the channel is busy for a while.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to