ChenSammi commented on PR #5157: URL: https://github.com/apache/ozone/pull/5157#issuecomment-1671064690
Hi @Galsza , overall the patch looks good to me. I would like to discuss about the wording used in the patch. There are words "remove", "clear" and "clean" used in client side CLI, SCM protocol file, and logic in SCM which delete the expired certificates from the rocksDB. Can we consolidate the words? for example, use "remove" in SCM side and "clean" in CLI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
