SaketaChalamchala commented on PR #5123: URL: https://github.com/apache/ozone/pull/5123#issuecomment-1677876382
> Thanks @SaketaChalamchala for the patch! > > Minor NIT: Would it be helpful to have a test where virtual-host style addressing is not used to verify if the canonical URI remains unchanged? Thanks for the review @tanvipenumudy, there are existing tests in TestStringToSignProducer.java#test and TestVirtualHostStyleFilter.java#testPathStyle that cover path style addressing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
