mladjan-gadzic commented on PR #5124: URL: https://github.com/apache/ozone/pull/5124#issuecomment-1678544856
> Thanks for working on the S3a compatibility @mladjan-gadzic. > > My understanding of `IOUtils#toString` is that it is going to do a full buffer copy and load the result into memory. I don't think we can do this for all data coming into s3g put. Can we just say if `ozone.s3g.fso.directory.creation` is enabled and a file is written with a trailing slash to an FSO bucket, we will treat it as a directory? Another more complicated option may be to seek past the auth header information in the stream to see if any content remains after that, but I'm not very familiar with the chunked layout authorization header format to know if this is feasible. Thanks @errose28 for taking the time to review this PR! I will try suggestions and let you know how it went. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
