kerneltime commented on code in PR #5162:
URL: https://github.com/apache/ozone/pull/5162#discussion_r1295212592
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java:
##########
@@ -630,4 +634,15 @@ public static OMRequest
blockMPUCompleteWithBucketLayoutFromOldClient(
}
return req;
}
+
+ private String multipartUploadedKeyHash(
+ OmMultipartKeyInfo.PartKeyInfoMap partsList) {
+ StringBuffer keysConcatenated = new StringBuffer();
+ for (PartKeyInfo partKeyInfo: partsList) {
+ keysConcatenated.append(partKeyInfo.getPartName());
+ }
+ return DigestUtils.md5Hex(keysConcatenated.toString()) + "-"
Review Comment:
How does this differentiate betweek 2 multipart uploads with varying data
but the same metadata?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java:
##########
@@ -630,4 +634,15 @@ public static OMRequest
blockMPUCompleteWithBucketLayoutFromOldClient(
}
return req;
}
+
+ private String multipartUploadedKeyHash(
+ OmMultipartKeyInfo.PartKeyInfoMap partsList) {
+ StringBuffer keysConcatenated = new StringBuffer();
+ for (PartKeyInfo partKeyInfo: partsList) {
+ keysConcatenated.append(partKeyInfo.getPartName());
+ }
+ return DigestUtils.md5Hex(keysConcatenated.toString()) + "-"
Review Comment:
How does this differentiate between 2 multipart uploads with varying data
but the same metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
